Bug 43242 - [Qt] Do not link to SharedBufferCF.cpp
Summary: [Qt] Do not link to SharedBufferCF.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Markus Goetz
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-07-30 05:45 PDT by Markus Goetz
Modified: 2010-08-02 07:48 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.10 KB, patch)
2010-07-30 08:59 PDT, Markus Goetz
no flags Details | Formatted Diff | Diff
Patch (1.76 KB, patch)
2010-08-02 06:57 PDT, Markus Goetz
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Goetz 2010-07-30 05:45:01 PDT
[Qt] Do not link to SharedBufferCF.cpp
Comment 1 Markus Goetz 2010-07-30 05:53:58 PDT
Patch coming soon..
Comment 2 Markus Goetz 2010-07-30 08:59:59 PDT
Created attachment 63064 [details]
Patch
Comment 3 WebKit Commit Bot 2010-07-30 09:02:02 PDT
Comment on attachment 63064 [details]
Patch

Rejecting patch 63064 from commit-queue.

markus.goetz@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact eseidel@chromium.org to request a commit-queue restart.  After restart the commit-queue will correctly respect your committer rights.
Comment 4 Tor Arne Vestbø 2010-07-30 09:06:00 PDT
Comment on attachment 63064 [details]
Patch


Let's look at this on monday.

> +        No new tests. (OOPS!)

Also, this oops has to go
Comment 5 Markus Goetz 2010-07-30 09:07:57 PDT
Comment on attachment 63064 [details]
Patch

have to speak with Tor Arne first..
Comment 6 Markus Goetz 2010-08-02 06:57:15 PDT
Created attachment 63213 [details]
Patch
Comment 7 Kenneth Rohde Christiansen 2010-08-02 07:01:39 PDT
Comment on attachment 63213 [details]
Patch

LGTM
Comment 8 Kenneth Rohde Christiansen 2010-08-02 07:02:20 PDT
Comment on attachment 63213 [details]
Patch

Oh, sorry I see that you want to talk to Tor Arne first. Removing cq+
Comment 9 Markus Goetz 2010-08-02 07:31:19 PDT
Thanks kenneth. The TorArne thing was about the previous patch, the current one should be fine. So cq+ is great with me.
Comment 10 WebKit Commit Bot 2010-08-02 07:48:21 PDT
Comment on attachment 63213 [details]
Patch

Clearing flags on attachment: 63213

Committed r64461: <http://trac.webkit.org/changeset/64461>
Comment 11 WebKit Commit Bot 2010-08-02 07:48:26 PDT
All reviewed patches have been landed.  Closing bug.