Bug 43236

Summary: Optimize SVGResources memory usage
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: krit, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Updated patch krit: review+

Nikolas Zimmermann
Reported 2010-07-30 02:43:24 PDT
marker*/clip-path/filter/fill/stroke properties can not be applied to all elements. We should be able to reduce memory usage of the class, by grouping properties that can be applied to certain element categories like "shapes" / "text content elements" / "graphics elements" / "container elements", as the SVG specification describes. Clipper & Filter & Masker can be grouped, MarkerStart & MarkerMid & MarkerEnd as well as Fill & Stroke.
Attachments
Patch (30.42 KB, patch)
2010-07-30 02:48 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Updated patch (30.44 KB, patch)
2010-07-30 02:53 PDT, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-07-30 02:48:29 PDT
Created attachment 63039 [details] Patch
Nikolas Zimmermann
Comment 2 2010-07-30 02:53:25 PDT
Created attachment 63041 [details] Updated patch Add missing ENABLE(FILTERS) guards.
Dirk Schulze
Comment 3 2010-07-30 04:00:52 PDT
Comment on attachment 63041 [details] Updated patch Talked about some changes on tag to clipper mapping. We don't follow the spec for defs,switch,pattern. r=me
Nikolas Zimmermann
Comment 4 2010-07-30 04:03:05 PDT
Thanks, landed in r64345.
Note You need to log in before you can comment on or make changes to this bug.