Bug 43234

Summary:

[QT] build fix for symbian

Product:

WebKit

Reporter:

Mahesh Kulkarni <maheshk>

Component:

WebCore JavaScript

Assignee:

Mahesh Kulkarni <maheshk>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hausmann, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	none
patch	none
patch	none
patch	none
patch	none
patch	hausmann: review+, hausmann: commit-queue+

Mahesh Kulkarni

Reported 2010-07-30 01:52:50 PDT

Build of qtwebkit on symbian has been broken since bugs.webkit.org/show_bug.cgi?id=43009 http://trac.webkit.org/changeset/64105

Attachments
patch (1015 bytes, patch) 2010-07-30 01:56 PDT, Mahesh Kulkarni	no flags	Details Formatted Diff Diff
patch (2.01 KB, patch) 2010-07-30 05:19 PDT, Mahesh Kulkarni	no flags	Details Formatted Diff Diff
patch (15.10 KB, patch) 2010-08-02 04:31 PDT, Mahesh Kulkarni	no flags	Details Formatted Diff Diff
patch (2.07 KB, patch) 2010-08-02 04:37 PDT, Mahesh Kulkarni	no flags	Details Formatted Diff Diff
patch (4.30 KB, patch) 2010-08-03 02:45 PDT, Mahesh Kulkarni	no flags	Details Formatted Diff Diff
patch (2.11 KB, patch) 2010-08-03 04:01 PDT, Mahesh Kulkarni	hausmann: review+ hausmann: commit-queue+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Mahesh Kulkarni

Comment 1 2010-07-30 01:56:19 PDT

Created attachment 63037 [details] patch Fixed symbian build issue

WebKit Commit Bot

Comment 2 2010-07-30 04:10:25 PDT

Comment on attachment 63037 [details] patch Clearing flags on attachment: 63037 Committed r64346: <http://trac.webkit.org/changeset/64346>

WebKit Commit Bot

Comment 3 2010-07-30 04:10:30 PDT

All reviewed patches have been landed. Closing bug.

Mahesh Kulkarni

Comment 4 2010-07-30 05:18:38 PDT

Found one more build issue. Patch coming soon

Mahesh Kulkarni

Comment 5 2010-07-30 05:19:59 PDT

Created attachment 63049 [details] patch found one more build issue. 1) parameter passing misplaced 2) casting error on symbian. Converted to int*

Mahesh Kulkarni

Comment 6 2010-08-02 04:31:57 PDT

Created attachment 63190 [details] patch As per comments from Simon on irc, changing static_cast to reinterpret_cast.

WebKit Review Bot

Comment 7 2010-08-02 04:33:00 PDT

Attachment 63190 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:49: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mahesh Kulkarni

Comment 8 2010-08-02 04:37:35 PDT

Created attachment 63191 [details] patch Corrected style issue and removed unintended changes :)

Simon Hausmann

Comment 9 2010-08-02 04:43:31 PDT

Comment on attachment 63191 [details] patch r=me

WebKit Commit Bot

Comment 10 2010-08-02 05:21:25 PDT

Comment on attachment 63191 [details] patch Clearing flags on attachment: 63191 Committed r64456: <http://trac.webkit.org/changeset/64456>

WebKit Commit Bot

Comment 11 2010-08-02 05:21:29 PDT

All reviewed patches have been landed. Closing bug.

Mahesh Kulkarni

Comment 12 2010-08-03 02:45:32 PDT

Created attachment 63311 [details] patch def file updated

Mahesh Kulkarni

Comment 13 2010-08-03 04:01:42 PDT

Created attachment 63315 [details] patch Updated patch for def files to mark missing exports as absent.

Simon Hausmann

Comment 14 2010-08-24 07:49:32 PDT

Removing from the 2.1 release blocker, as the 2.1 release branch is not affected by the refactorings.

Note You need to log in before you can comment on or make changes to this bug.