Summary: | [QT] build fix for symbian | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mahesh Kulkarni <maheshk> | ||||||||||||||
Component: | WebCore JavaScript | Assignee: | Mahesh Kulkarni <maheshk> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | commit-queue, hausmann, webkit.review.bot | ||||||||||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | PC | ||||||||||||||||
OS: | OS X 10.5 | ||||||||||||||||
Attachments: |
|
Description
Mahesh Kulkarni
2010-07-30 01:52:50 PDT
Created attachment 63037 [details]
patch
Fixed symbian build issue
Comment on attachment 63037 [details] patch Clearing flags on attachment: 63037 Committed r64346: <http://trac.webkit.org/changeset/64346> All reviewed patches have been landed. Closing bug. Found one more build issue. Patch coming soon Created attachment 63049 [details]
patch
found one more build issue.
1) parameter passing misplaced
2) casting error on symbian. Converted to int*
Created attachment 63190 [details]
patch
As per comments from Simon on irc, changing static_cast to reinterpret_cast.
Attachment 63190 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:49: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 63191 [details]
patch
Corrected style issue and removed unintended changes :)
Comment on attachment 63191 [details]
patch
r=me
Comment on attachment 63191 [details] patch Clearing flags on attachment: 63191 Committed r64456: <http://trac.webkit.org/changeset/64456> All reviewed patches have been landed. Closing bug. Created attachment 63311 [details]
patch
def file updated
Created attachment 63315 [details]
patch
Updated patch for def files to mark missing exports as absent.
Removing from the 2.1 release blocker, as the 2.1 release branch is not affected by the refactorings. |