Bug 43226

Summary: Canvas test 2d.composite.operation.clear failing
Product: WebKit Reporter: Matthew Delaney <mdelaney7>
Component: Layout and RenderingAssignee: Matthew Delaney <mdelaney7>
Status: RESOLVED FIXED    
Severity: Minor CC: adele, commit-queue, kling
Priority: P3 Keywords: HTML5
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Updated name of test
none
Patch none

Matthew Delaney
Reported 2010-07-29 18:04:42 PDT
The canvas test 2d.composite.operation.clear fails because webkit supports a vendor specific composite op named "clear" that doesn't follow the conventions of the spec - should be named "webkit-clear" per the spec. However, for compatibility reasons, it doesn't currently make sense to drop the op (or drop by renaming it). Thus, I leave the test to remain on the skip list and make a second version of the test called 2d.composite.operation.clear2 that tests for a bogus op to make sure that we ignore unrecognized ops.
Attachments
Patch (3.63 KB, patch)
2010-07-29 18:07 PDT, Matthew Delaney 		no flags
DetailsFormatted DiffDiff
Patch (3.65 KB, patch)
2010-07-30 13:45 PDT, Matthew Delaney 		no flags
DetailsFormatted DiffDiff
Updated name of test (3.66 KB, patch)
2010-08-11 11:14 PDT, Matthew Delaney 		no flags
DetailsFormatted DiffDiff
Patch (3.63 KB, patch)
2010-08-26 18:04 PDT, Matthew Delaney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Matthew Delaney
Comment 1 2010-07-29 18:07:37 PDT
Created attachment 63019 [details] Patch
Adele Peterson
Comment 2 2010-07-30 10:25:26 PDT
Comment on attachment 63019 [details] Patch Can we support "clear" and "webkit-clear"?
Adele Peterson
Comment 3 2010-07-30 11:09:05 PDT
After understanding this better, that doesn't seem like that good an idea. (In reply to comment #2) > (From update of attachment 63019 [details]) > Can we support "clear" and "webkit-clear"?
Matthew Delaney
Comment 4 2010-07-30 13:45:43 PDT
Created attachment 63099 [details] Patch
Matthew Delaney
Comment 5 2010-08-11 11:14:51 PDT
Created attachment 64137 [details] Updated name of test Just updated the name of the new test to avoid any confusion as to the nature of the test.
Andreas Kling
Comment 6 2010-08-16 17:53:47 PDT
FWIW, this LGTM.
Matthew Delaney
Comment 7 2010-08-26 18:04:47 PDT
Created attachment 65654 [details] Patch
Oliver Hunt
Comment 8 2010-08-26 18:06:27 PDT
Comment on attachment 65654 [details] Patch r=me
WebKit Commit Bot
Comment 9 2010-08-27 19:42:08 PDT
Comment on attachment 65654 [details] Patch Clearing flags on attachment: 65654 Committed r66294: <http://trac.webkit.org/changeset/66294>
WebKit Commit Bot
Comment 10 2010-08-27 19:42:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.