Bug 43206

Summary: Ask a canvas' rendering context if it is accelerated instead tying it directly to webgl
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, senorblanco, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch simon.fraser: review+

James Robinson
Reported 2010-07-29 12:58:47 PDT
Ask a canvas' rendering context if it is accelerated instead tying it directly to webgl
Attachments
Patch (4.07 KB, patch)
2010-07-29 13:01 PDT, James Robinson 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2010-07-29 13:01:02 PDT
Created attachment 62978 [details] Patch
Simon Fraser (smfr)
Comment 2 2010-07-29 13:10:04 PDT
Comment on attachment 62978 [details] Patch > #if ENABLE(3D_CANVAS) > HTMLCanvasElement* canvas = static_cast<HTMLCanvasElement*>(node()); > - return canvas && canvas->is3D(); > + return canvas && canvas->renderingContext() && canvas->renderingContext()->isAccelerated(); No need for the #if ENABLE(3D_CANVAS) any more?
James Robinson
Comment 3 2010-07-29 13:37:50 PDT
True, I'll get rid of the #ifs.
James Robinson
Comment 4 2010-07-29 14:35:47 PDT
Committed r64308: <http://trac.webkit.org/changeset/64308>
Note You need to log in before you can comment on or make changes to this bug.