Bug 43193

Summary:

Initialize all members of NPClass struct

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

43191

Attachments:

Description	Flags
proposed patch	none

Description Csaba Osztrogonác 2010-07-29 09:01:12 PDT

We should initialize all members of NPClass struct to avoid gcc warnings.

Warnings on Qt bots:
/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:119: warning: missing initializer for member ‘NPClass::removeProperty’
/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:119: warning: missing initializer for member ‘NPClass::enumerate’
/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:119: warning: missing initializer for member ‘NPClass::construct’

Comment 1 Csaba Osztrogonác 2010-07-29 09:05:14 PDT

Created attachment 62953 [details]
proposed patch

Members of "static NPClass pluginClass" are initialized with zeros by crt0.
We can do it explicitly to avoid gcc warnings.

Comment 2 Csaba Osztrogonác 2010-07-29 09:36:43 PDT

Comment on attachment 62953 [details]
proposed patch

Clearing flags on attachment: 62953

Committed r64285: <http://trac.webkit.org/changeset/64285>

Comment 3 Csaba Osztrogonác 2010-07-29 09:38:31 PDT

All reviewed patches have been landed.  Closing bug.