Bug 43192

Summary:

Warning fix on platforms where XP_MACOSX is undefined.

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

43191

Attachments:

Description	Flags
accidentally uploaded	none
proposed patch	none

Description Csaba Osztrogonác 2010-07-29 08:46:35 PDT

Warnings on Qt buildbot:

/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.h:28:5: warning: "XP_MACOSX" is not defined
/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.h:69:5: warning: "XP_MACOSX" is not defined
/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.h:83:5: warning: "XP_MACOSX" is not defined

Comment 1 Csaba Osztrogonác 2010-07-29 08:48:52 PDT

Created attachment 62950 [details]
accidentally uploaded

We can use #if defined(XP_MACOSX) instead of #if XP_MACOSX ,
because XP_MACOSX is 1 when it is defined.

Comment 2 Csaba Osztrogonác 2010-07-29 08:51:10 PDT

Created attachment 62951 [details]
proposed patch

We can use #if defined(XP_MACOSX) instead of #if XP_MACOSX ,
because XP_MACOSX is 1 when it is defined.

Comment 3 Antonio Gomes 2010-07-29 08:55:47 PDT

Comment on attachment 62951 [details]
proposed patch

r=me , can you wait green builtbots before commit, please?

Comment 4 Csaba Osztrogonác 2010-07-29 09:14:03 PDT

Comment on attachment 62951 [details]
proposed patch

Clearing flags on attachment: 62951

Committed r64282: <http://trac.webkit.org/changeset/64282>

Comment 5 Csaba Osztrogonác 2010-07-29 09:14:11 PDT

All reviewed patches have been landed.  Closing bug.