Bug 43190

Summary: Rename all the IDBIndex classses to match the latest conventions
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Jeremy Orlow <jorlow>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, bulach, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 42969    
Attachments:
Description Flags
Patch steveblock: review+

Jeremy Orlow
Reported 2010-07-29 07:39:11 PDT
Rename all the IDBIndex classses to match the latest conventions
Attachments
Patch (61.74 KB, patch)
2010-07-29 07:48 PDT, Jeremy Orlow 		steveblock: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2010-07-29 07:48:54 PDT
Created attachment 62945 [details] Patch
Jeremy Orlow
Comment 2 2010-07-29 07:49:59 PDT
The diff didn't handle the IDBIndex.h -> IDBIndexBackendInterface.h and IDBIndexRequest.h -> IDBIndex.h change gracefully. Otherwise ready for review.
Steve Block
Comment 3 2010-07-29 08:10:50 PDT
Comment on attachment 62945 [details] Patch WebCore/ChangeLog:13 + up the naming in general to make things more clear. In the future, we're It would be good if you could list the before and after name for each class. Or even split this change into two - a renaming due to the spec change, plus a clean-up.
Jeremy Orlow
Comment 4 2010-07-29 08:13:50 PDT
There's almost no cleanup in this patch. And the little there is should be quite obviously correct. (Stuff like a variable being "Index" instead of "index".) IDBIndex -> IDBIndexBackendInterface IDBImpl -> IDBIndexBackendImpl IDBIndexRequest -> IDBIndex
Jeremy Orlow
Comment 5 2010-07-29 08:14:07 PDT
Er...IDBIndexImpl -> IDBIndexBackendImpl
Steve Block
Comment 6 2010-07-29 09:08:03 PDT
Comment on attachment 62945 [details] Patch WebCore/CMakeLists.txt:1440 + storage/IDBIndexBackendImpl.cpp Were these missing before?
Jeremy Orlow
Comment 7 2010-07-29 09:13:24 PDT
(In reply to comment #6) > (From update of attachment 62945 [details]) > WebCore/CMakeLists.txt:1440 > + storage/IDBIndexBackendImpl.cpp > Were these missing before? Yup.
Jeremy Orlow
Comment 8 2010-07-30 08:30:20 PDT
Committed r64358: <http://trac.webkit.org/changeset/64358>
Note You need to log in before you can comment on or make changes to this bug.