Bug 43176

Summary: [WML] Add dummy argument to SelectElement::defaultEventHandler() in WMLSelectElement
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, hyuki.kim, ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
patch none

Gyuyoung Kim
Reported 2010-07-29 00:31:43 PDT
An parameter was added to defaultEventHandler() of SelectElement. So, WMLSelectElement should use the defaultEventHandler with 4 parameters. However, the new parameter is HTMLFormElement. It is difficult to set the HTMLFormElement in WMLSelectElement.cpp. For now, I add NULL instead of the HTMLFormElement in order to prevent build break when wml is enabled. IMO, this issue should be fixed later.
Attachments
Patch (1.23 KB, patch)
2010-07-29 00:33 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
patch (1.23 KB, patch)
2010-07-29 00:43 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2010-07-29 00:33:52 PDT
Created attachment 62924 [details] Patch
WebKit Review Bot
Comment 2 2010-07-29 00:35:09 PDT
Attachment 62924 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/wml/WMLSelectElement.cpp:170: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gyuyoung Kim
Comment 3 2010-07-29 00:43:05 PDT
Created attachment 62925 [details] patch I change NULL with 0.
Eric Seidel (no email)
Comment 4 2010-08-07 20:01:03 PDT
Comment on attachment 62925 [details] patch Clearing flags on attachment: 62925 Committed r64931: <http://trac.webkit.org/changeset/64931>
Eric Seidel (no email)
Comment 5 2010-08-07 20:01:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.