Summary: | [WML] Add KURL parameter to WMLDocument::create() | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, commit-queue, eric, hyuki.kim, michael3myers1 | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Gyuyoung Kim
2010-07-28 23:16:42 PDT
Created attachment 62919 [details]
Patch
Patch.
Hello Eric, Could you please review this patch? Comment on attachment 62919 [details]
Patch
Why? Neither your bug or your ChangeLog say why?
Is this a build fix?
Created attachment 63795 [details] Patch (In reply to comment #3) > (From update of attachment 62919 [details]) > Why? Neither your bug or your ChangeLog say why? > > Is this a build fix? Yes, right. This patch is to fix build break. WMLDocument inherits Document class as below, WMLDocument::WMLDocument(Frame* frame) : Document(frame, false, false) However, the Document Class's construct parameters were changed. url was added. Document::Document(Frame* frame, const KURL& url, bool isXHTML, bool isHTML) So. I make this patch to fix build break when wml is enabled. I add comment to Changelog. Created attachment 63798 [details]
Patch
Previous patch has something wrong. I upload this patch again.
Thank you.
Comment on attachment 63795 [details]
Patch
Looks fine. Looks like it does not apply though.
Comment on attachment 63798 [details] Patch Clearing flags on attachment: 63798 Committed r64941: <http://trac.webkit.org/changeset/64941> All reviewed patches have been landed. Closing bug. |