Bug 43173

Summary: [WML] Add KURL parameter to WMLDocument::create()
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, eric, hyuki.kim, michael3myers1
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
eric: review-
Patch
none
Patch none

Gyuyoung Kim
Reported 2010-07-28 23:16:42 PDT
An url parameter was added to Document class. So. WMLDocument should support url parameter as well.
Attachments
Patch (1.88 KB, patch)
2010-07-28 23:20 PDT, Gyuyoung Kim 		eric: review-
DetailsFormatted DiffDiff
Patch (1.99 KB, patch)
2010-08-06 19:22 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (1.99 KB, patch)
2010-08-06 20:10 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2010-07-28 23:20:31 PDT
Created attachment 62919 [details] Patch Patch.
Gyuyoung Kim
Comment 2 2010-08-05 18:31:36 PDT
Hello Eric, Could you please review this patch?
Eric Seidel (no email)
Comment 3 2010-08-06 10:45:15 PDT
Comment on attachment 62919 [details] Patch Why? Neither your bug or your ChangeLog say why? Is this a build fix?
Gyuyoung Kim
Comment 4 2010-08-06 19:22:40 PDT
Created attachment 63795 [details] Patch (In reply to comment #3) > (From update of attachment 62919 [details]) > Why? Neither your bug or your ChangeLog say why? > > Is this a build fix? Yes, right. This patch is to fix build break. WMLDocument inherits Document class as below, WMLDocument::WMLDocument(Frame* frame) : Document(frame, false, false) However, the Document Class's construct parameters were changed. url was added. Document::Document(Frame* frame, const KURL& url, bool isXHTML, bool isHTML) So. I make this patch to fix build break when wml is enabled. I add comment to Changelog.
Gyuyoung Kim
Comment 5 2010-08-06 20:10:33 PDT
Created attachment 63798 [details] Patch Previous patch has something wrong. I upload this patch again. Thank you.
Eric Seidel (no email)
Comment 6 2010-08-06 20:10:43 PDT
Comment on attachment 63795 [details] Patch Looks fine. Looks like it does not apply though.
Eric Seidel (no email)
Comment 7 2010-08-07 23:45:42 PDT
Comment on attachment 63798 [details] Patch Clearing flags on attachment: 63798 Committed r64941: <http://trac.webkit.org/changeset/64941>
Eric Seidel (no email)
Comment 8 2010-08-07 23:45:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.