Bug 43162

Summary:

Add support for MADV_FREE to PageAllocation

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

JavaScriptCore

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-ews

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
The patch	none
Errk, better patch	darin: review-
Even better patch!	darin: review+

Gavin Barraclough

Reported 2010-07-28 17:24:22 PDT

This is useful on platforms that don't have MADV_FREE_REUS(ABL)E.

Attachments
The patch (1.38 KB, patch) 2010-07-28 17:27 PDT, Gavin Barraclough	no flags	Details Formatted Diff Diff
Errk, better patch (1.95 KB, patch) 2010-07-28 17:29 PDT, Gavin Barraclough	darin: review-	Details Formatted Diff Diff
Even better patch! (2.28 KB, patch) 2010-07-28 18:13 PDT, Gavin Barraclough	darin: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Gavin Barraclough

Comment 1 2010-07-28 17:27:52 PDT

Created attachment 62897 [details] The patch

Gavin Barraclough

Comment 2 2010-07-28 17:29:53 PDT

Created attachment 62898 [details] Errk, better patch

Early Warning System Bot

Comment 3 2010-07-28 17:32:50 PDT

Attachment 62897 [details] did not build on qt: Build output: http://queues.webkit.org/results/3596522

Darin Adler

Comment 4 2010-07-28 17:36:02 PDT

Comment on attachment 62898 [details] Errk, better patch I think this would be more readable if the #ifs were moved exclusively inside the commit and decommit functions. This won't compile because you've left the argument names out even though you are using them in decommit.

Gavin Barraclough

Comment 5 2010-07-28 18:13:13 PDT

Created attachment 62908 [details] Even better patch!

Gavin Barraclough

Comment 6 2010-07-28 20:22:54 PDT

Transmitting file data .. Committed revision 64261.

Note You need to log in before you can comment on or make changes to this bug.