Summary: | Implement NPN_Invoke | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Anders Carlsson
2010-07-28 16:25:25 PDT
Created attachment 62890 [details]
Patch
Comment on attachment 62890 [details]
Patch
A bunch of *'s on the wrong side.
Otherwise, r=me.
Attachment 62890 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:533: NPN_Invoke is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/WebProcess/Plugins/NPJSObject.cpp:219: NPJSObject::NP_Invoke is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 2 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r64244: <http://trac.webkit.org/changeset/64244> |