Bug 43158 - Implement NPN_Invoke
Summary: Implement NPN_Invoke
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
Depends on:
Reported: 2010-07-28 16:25 PDT by Anders Carlsson
Modified: 2010-07-28 16:38 PDT (History)
1 user (show)

See Also:

Patch (6.31 KB, patch)
2010-07-28 16:28 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-28 16:25:25 PDT
Implement NPN_Invoke
Comment 1 Anders Carlsson 2010-07-28 16:28:07 PDT
Created attachment 62890 [details]
Comment 2 Sam Weinig 2010-07-28 16:32:09 PDT
Comment on attachment 62890 [details]

A bunch of *'s on the wrong side.

Otherwise, r=me.
Comment 3 WebKit Review Bot 2010-07-28 16:34:06 PDT
Attachment 62890 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:533:  NPN_Invoke is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/Plugins/NPJSObject.cpp:219:  NPJSObject::NP_Invoke is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 5 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Anders Carlsson 2010-07-28 16:38:54 PDT
Committed r64244: <http://trac.webkit.org/changeset/64244>