Summary: | Minor compile errors in loadMediaPlayerProxyPlugin | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Bryan Gislason <bgislason58> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, japhet | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | Other | ||||||||
Attachments: |
|
Comment on attachment 62870 [details]
3 small fixes
Code looks fine, but you need a ChangeLog.
WebKitTools/Scripts/prepare-changelog will give you a stub in WebCore/ChangeLog that you can fill out.
Created attachment 62884 [details]
add a changelog
Comment on attachment 62884 [details]
add a changelog
Thanks!
Comment on attachment 62884 [details] add a changelog Clearing flags on attachment: 62884 Committed r64262: <http://trac.webkit.org/changeset/64262> All reviewed patches have been landed. Closing bug. |
Created attachment 62870 [details] 3 small fixes These were not caught in initial compile because PLUGIN_PROXY_PROXY_FOR_VIDEO was not enabled.