Bug 43098

Summary: Web Inspector: Enable UI for chromium's appcache inspection.
Product: WebKit Reporter: Kavita Kanetkar <kkanetkar>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, joepeck, keishi, michaeln, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch - Added Settings.js none

Kavita Kanetkar
Reported 2010-07-27 18:37:49 PDT
Enable UI for appcache inspection. Should I remove the condition in StoragePanel.js so that the UI always shows appcache? Or should I just set Preferences.appCacheEnabled = true; for chromium in DevTools.js?
Attachments
patch (3.63 KB, patch)
2010-07-28 12:57 PDT, Kavita Kanetkar 		no flags
DetailsFormatted DiffDiff
patch - Added Settings.js (4.14 KB, patch)
2010-07-28 14:57 PDT, Kavita Kanetkar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2010-07-27 18:42:55 PDT
Removing the condition sounds good. I don't think anyone would want to opt-in to having it disabled.
Kavita Kanetkar
Comment 2 2010-07-28 12:57:08 PDT
Created attachment 62868 [details] patch
Kavita Kanetkar
Comment 3 2010-07-28 13:01:06 PDT
Do I need to modify WebCore/inspector/front-end/Settings.js ? And completely remove it from there as well? Thanks, Kavita
Pavel Feldman
Comment 4 2010-07-28 13:09:40 PDT
Comment on attachment 62868 [details] patch Yes, please remote it from settings too!
Pavel Feldman
Comment 5 2010-07-28 14:08:08 PDT
s/remote/remove/
Kavita Kanetkar
Comment 6 2010-07-28 14:57:56 PDT
Created attachment 62881 [details] patch - Added Settings.js
WebKit Commit Bot
Comment 7 2010-07-28 22:53:02 PDT
Comment on attachment 62881 [details] patch - Added Settings.js Clearing flags on attachment: 62881 Committed r64265: <http://trac.webkit.org/changeset/64265>
WebKit Commit Bot
Comment 8 2010-07-28 22:53:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.