Bug 43098 - Web Inspector: Enable UI for chromium's appcache inspection.
Summary: Web Inspector: Enable UI for chromium's appcache inspection.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-27 18:37 PDT by Kavita Kanetkar
Modified: 2010-07-28 22:53 PDT (History)
10 users (show)

See Also:

Attachments
patch (3.63 KB, patch)
2010-07-28 12:57 PDT, Kavita Kanetkar 		no flags Details | Formatted Diff | Diff
patch - Added Settings.js (4.14 KB, patch)
2010-07-28 14:57 PDT, Kavita Kanetkar 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kavita Kanetkar 2010-07-27 18:37:49 PDT 
Enable UI for appcache inspection.

Should I remove the condition in StoragePanel.js so that the UI always shows appcache? Or should I just set Preferences.appCacheEnabled = true;
for chromium in DevTools.js?
Comment 1 Joseph Pecoraro 2010-07-27 18:42:55 PDT 
Removing the condition sounds good. I don't think anyone
would want to opt-in to having it disabled.
Comment 2 Kavita Kanetkar 2010-07-28 12:57:08 PDT 
Created attachment 62868 [details]
patch
Comment 3 Kavita Kanetkar 2010-07-28 13:01:06 PDT 
Do I need to modify 
WebCore/inspector/front-end/Settings.js ? And completely remove it from there as well?

Thanks,
Kavita
Comment 4 Pavel Feldman 2010-07-28 13:09:40 PDT 
Comment on attachment 62868 [details]
patch

Yes, please remote it from settings too!
Comment 5 Pavel Feldman 2010-07-28 14:08:08 PDT 
s/remote/remove/
Comment 6 Kavita Kanetkar 2010-07-28 14:57:56 PDT 
Created attachment 62881 [details]
patch - Added Settings.js
Comment 7 WebKit Commit Bot 2010-07-28 22:53:02 PDT 
Comment on attachment 62881 [details]
patch - Added Settings.js

Clearing flags on attachment: 62881

Committed r64265: <http://trac.webkit.org/changeset/64265>
Comment 8 WebKit Commit Bot 2010-07-28 22:53:07 PDT 
All reviewed patches have been landed.  Closing bug.