Summary: | Cleanup JIT related switched in Platform.h | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fu, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Gavin Barraclough
2010-07-27 15:49:18 PDT
Created attachment 62764 [details]
The patch
Attachment 62764 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/jit/ExecutableAllocator.h:202: Missing space after , [whitespace/comma] [3]
JavaScriptCore/jit/ExecutableAllocator.h:203: Missing space after , [whitespace/comma] [3]
JavaScriptCore/wtf/Platform.h:923: Missing space after , [whitespace/comma] [3]
JavaScriptCore/wtf/Platform.h:930: Missing space after , [whitespace/comma] [3]
Total errors found: 4 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
There is a typo in ExecutableAllocator.h for MIPS. We need to use ! for the macro to test if GCC is < 4.4.3. Thanks! Ex: Index: ExecutableAllocator.h =================================================================== --- ExecutableAllocator.h (revision 64473) +++ ExecutableAllocator.h (working copy) @@ -200,7 +200,7 @@ static void cacheFlush(void* code, size_t size) { #if COMPILER(GCC) && GCC_VERSION_AT_LEAST(4,3,0) -#if WTF_MIPS_ISA_REV(2) && GCC_VERSION_AT_LEAST(4,4,3) +#if WTF_MIPS_ISA_REV(2) && !GCC_VERSION_AT_LEAST(4,4,3) int lineSize; asm("rdhwr %0, $1" : "=r" (lineSize)); // Regards, Chao-ying Ooops, sorry Chao-ying, will fix this. Thanks! G. |