Bug 43088

Summary: [GTK] Use GdkPixbuf for ImageBuffer::toDataURL
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Use GdkPixbuf for toDataURL xan.lopez: review+

Martin Robinson
Reported 2010-07-27 15:42:01 PDT
Currently, this method is implemented via Cairo, and so does not have access to the richer set of image types that GdkPixbuf supports. Unfortunately, GdkPixbuf cannot write GIF files, so that format will still be unsupported.
Attachments
Use GdkPixbuf for toDataURL (18.37 KB, patch)
2010-07-27 15:54 PDT, Martin Robinson 		xan.lopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-07-27 15:54:58 PDT
Created attachment 62763 [details] Use GdkPixbuf for toDataURL
WebKit Review Bot
Comment 2 2010-07-27 15:57:05 PDT
Attachment 62763 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/graphics/gtk/CairoUtilities.h:29: cairo_surface_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/graphics/gtk/ImageBufferGtk.cpp:64: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/graphics/gtk/ImageBufferGtk.cpp:66: Use 0 instead of NULL. [readability/null] [5] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Martin Robinson
Comment 3 2010-07-27 16:10:59 PDT
The first error is a false positive, because I just add the cairo typedef to avoid the include. The second error I've filed a bug for here: https://bugs.webkit.org/show_bug.cgi?id=43090
Xan Lopez
Comment 4 2010-08-02 14:03:48 PDT
Comment on attachment 62763 [details] Use GdkPixbuf for toDataURL The code in ImageBufferGtk should probably be LGPL, but other than that it looks OK.
Martin Robinson
Comment 5 2010-08-02 16:52:22 PDT
Committed r64506: <http://trac.webkit.org/changeset/64506>
WebKit Review Bot
Comment 6 2010-08-02 17:31:53 PDT
http://trac.webkit.org/changeset/64506 might have broken GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/64506 http://trac.webkit.org/changeset/64507
Martin Robinson
Comment 7 2010-08-02 19:01:41 PDT
Committed r64521: <http://trac.webkit.org/changeset/64521>
Note You need to log in before you can comment on or make changes to this bug.