Bug 43081

Summary: Unify blob related feature defines to ENABLE(BLOB)
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore JavaScriptAssignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dimich, eric, kinuko, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Patch
levin: review-, jianli: commit-queue-
Proposed Patch levin: review+, jianli: commit-queue-

Description Jian Li 2010-07-27 14:56:41 PDT 
We have quite a few feature defines for blob related features, like ENABLE(BLOB_SLICE) and ENABLE(FILE_READER). We do not want another feature define when we start to support blob URL. Thus it would be better if we could unify all blob related defines to one simple define. So we need to change ENABLE(BLOB_SLICE) and ENABLE(FILE_READER) to ENABLE(BLOB). The future work of blob URL is also going to put under ENABLE(BLOB). Note that ENABLE(FILE_WRITER) remains unchanged since it is also related to file system work and thus it needs additional guard.
Comment 1 Jian Li 2010-07-27 17:39:44 PDT 
Created attachment 62779 [details]
Proposed Patch
Comment 2 David Levin 2010-07-27 17:52:44 PDT 
Comment on attachment 62779 [details]
Proposed Patch

r- due to removal of if's in BlobItem.* as discussed.
Comment 3 Jian Li 2010-07-27 18:00:34 PDT 
Created attachment 62780 [details]
Proposed Patch

Fixed.
Comment 4 WebKit Review Bot 2010-08-05 11:06:13 PDT 
http://trac.webkit.org/changeset/64763 might have broken Qt Linux Release
Comment 5 Jian Li 2010-08-05 11:30:09 PDT 
Committed as http://trac.webkit.org/changeset/64763.