Bug 43076

Summary: [Chromium] Add the ability to show right-aligned icons in the AutoFill popup.
Product: WebKit Reporter: James Hawkins <jhawkins>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dhollowa, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch fishd: review+

James Hawkins
Reported 2010-07-27 13:53:35 PDT
[Chromium] Add the ability to show right-aligned icons in the AutoFill popup.
Attachments
Patch (16.78 KB, patch)
2010-07-27 13:55 PDT, James Hawkins 		no flags
DetailsFormatted DiffDiff
Patch (16.79 KB, patch)
2010-07-27 15:48 PDT, James Hawkins 		fishd: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Hawkins
Comment 1 2010-07-27 13:55:49 PDT
Created attachment 62742 [details] Patch
James Hawkins
Comment 2 2010-07-27 15:48:56 PDT
Created attachment 62759 [details] Patch
James Hawkins
Comment 3 2010-07-27 15:50:05 PDT
Fixed a leak by using RefPtr to accept a PassRefPtr.
Darin Fisher (:fishd, Google)
Comment 4 2010-07-27 15:50:31 PDT
Comment on attachment 62759 [details] Patch good catch on the memory leak. r=me
David Holloway
Comment 5 2010-07-27 15:51:42 PDT
LGTM.
James Hawkins
Comment 6 2010-07-27 16:02:13 PDT
Committed r64173: <http://trac.webkit.org/changeset/64173>
Note You need to log in before you can comment on or make changes to this bug.