Summary: | Move NPJSObject out into separate files | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Anders Carlsson
2010-07-27 12:22:26 PDT
Created attachment 62725 [details]
Patch
Comment on attachment 62725 [details]
Patch
r=me
Attachment 62725 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/Plugins/NPJSObject.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/WebProcess/Plugins/NPJSObject.cpp:129: NPJSObject::NP_Allocate is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/WebProcess/Plugins/NPJSObject.cpp:136: NPJSObject::NP_Deallocate is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/WebProcess/Plugins/NPJSObject.cpp:142: NPJSObject::NP_HasProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/WebProcess/Plugins/NPJSObject.cpp:147: NPJSObject::NP_GetProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/WebProcess/Plugins/NPRuntimeObjectMap.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebKit2/WebProcess/Plugins/NPJSObject.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebKit2/WebProcess/Plugins/NPJSObject.h:66: NP_Allocate is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/WebProcess/Plugins/NPJSObject.h:67: NP_Deallocate is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/WebProcess/Plugins/NPJSObject.h:68: NP_HasProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/WebProcess/Plugins/NPJSObject.h:69: NP_GetProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 11 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r64147: <http://trac.webkit.org/changeset/64147> |