Bug 43052

Summary:

[IndexedDB] Key range methods belong to the IDBKeyRange interface

Product:

WebKit

Reporter:

Andrei Popescu <andreip>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bulach, dglazkov, jorlow, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

42966

Attachments:

Description	Flags
Patch	none
Patch	jorlow: review+

Description Andrei Popescu 2010-07-27 08:43:27 PDT

[IndexedDB] Key range methods belong to the IDBKeyRange interface

Comment 1 Andrei Popescu 2010-07-27 08:50:48 PDT

Created attachment 62697 [details]
Patch

Comment 2 WebKit Review Bot 2010-07-27 09:10:09 PDT

Attachment 62697 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/3621177

Comment 3 Andrei Popescu 2010-07-27 10:07:41 PDT

Created attachment 62707 [details]
Patch

Comment 4 Jeremy Orlow 2010-07-27 10:34:42 PDT

Comment on attachment 62707 [details]
Patch

WebCore/page/DOMWindow.cpp:487
 +      m_idb_key_range = 0;
not user hacker style

WebCore/page/DOMWindow.cpp:715
 +  
space isn't really necessary...but not super worried about it.

WebCore/page/DOMWindow.h:235
 +          IDBKeyRange* iDBKeyRange() const;
Does casing it like this even work?

r=me

Comment 5 Andrei Popescu 2010-07-27 11:04:46 PDT

Committed r64141: <http://trac.webkit.org/changeset/64141>

Comment 6 Marcus Bulach 2010-08-10 06:37:55 PDT

*** Bug 41170 has been marked as a duplicate of this bug. ***