Bug 43052

Summary: [IndexedDB] Key range methods belong to the IDBKeyRange interface
Product: WebKit Reporter: Andrei Popescu <andreip>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bulach, dglazkov, jorlow, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 42966    
Attachments:
Description Flags
Patch
none
Patch jorlow: review+

Andrei Popescu
Reported 2010-07-27 08:43:27 PDT
[IndexedDB] Key range methods belong to the IDBKeyRange interface
Attachments
Patch (12.91 KB, patch)
2010-07-27 08:50 PDT, Andrei Popescu 		no flags
DetailsFormatted DiffDiff
Patch (12.89 KB, patch)
2010-07-27 10:07 PDT, Andrei Popescu 		jorlow: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrei Popescu
Comment 1 2010-07-27 08:50:48 PDT
Created attachment 62697 [details] Patch
WebKit Review Bot
Comment 2 2010-07-27 09:10:09 PDT
Attachment 62697 [details] did not build on chromium: Build output: http://queues.webkit.org/results/3621177
Andrei Popescu
Comment 3 2010-07-27 10:07:41 PDT
Created attachment 62707 [details] Patch
Jeremy Orlow
Comment 4 2010-07-27 10:34:42 PDT
Comment on attachment 62707 [details] Patch WebCore/page/DOMWindow.cpp:487 + m_idb_key_range = 0; not user hacker style WebCore/page/DOMWindow.cpp:715 + space isn't really necessary...but not super worried about it. WebCore/page/DOMWindow.h:235 + IDBKeyRange* iDBKeyRange() const; Does casing it like this even work? r=me
Andrei Popescu
Comment 5 2010-07-27 11:04:46 PDT
Committed r64141: <http://trac.webkit.org/changeset/64141>
Marcus Bulach
Comment 6 2010-08-10 06:37:55 PDT
*** Bug 41170 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.