Bug 43019

Summary:

Plug-in views should be able to return JSObjects directly

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	sam: review+

Description Anders Carlsson 2010-07-26 17:02:23 PDT

Plug-in views should be able to return JSObjects directly

Comment 1 Anders Carlsson 2010-07-26 17:05:53 PDT

Created attachment 62631 [details]
Patch

Comment 2 WebKit Review Bot 2010-07-26 17:07:07 PDT

Attachment 62631 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/plugins/PluginViewBase.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Sam Weinig 2010-07-26 17:07:41 PDT

Comment on attachment 62631 [details]
Patch

Lovely. r=me

Comment 4 Anders Carlsson 2010-07-26 17:09:22 PDT

Committed r64093: <http://trac.webkit.org/changeset/64093>