Bug 42935

Summary: [MSVC] Ensure 4 byte alignment on ARM
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch none

Patrick R. Gansterer
Reported 2010-07-24 06:06:11 PDT
see patch
Attachments
Patch (1.45 KB, patch)
2010-07-24 06:07 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-07-24 06:07:26 PDT
Created attachment 62502 [details] Patch
Darin Adler
Comment 2 2010-07-24 12:41:23 PDT
Comment on attachment 62502 [details] Patch > +#if COMPILER(MSVC) > +#pragma pack(push) > +#pragma pack(4) > +#endif // COMPILER(MSVC) I think having a comment on an endif that is only 2 lines away from the #if is overkill! > +#if COMPILER(MSVC) > +#pragma pack(pop) > +#endif // COMPILER(MSVC) And even moreso here.
Patrick R. Gansterer
Comment 3 2010-07-24 12:45:45 PDT
(In reply to comment #2) > I think having a comment on an endif that is only 2 lines away from the #if is overkill! I think too, but I only did the same like for the X86 part. ;-)
WebKit Commit Bot
Comment 4 2010-07-24 17:40:41 PDT
Comment on attachment 62502 [details] Patch Clearing flags on attachment: 62502 Committed r64017: <http://trac.webkit.org/changeset/64017>
WebKit Commit Bot
Comment 5 2010-07-24 17:40:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.