| Summary: | Cleanup defines in Platform.h | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||
| Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Patrick R. Gansterer
2010-07-24 05:43:44 PDT
Created attachment 62500 [details]
Patch
All defines are handeld by buildsystem now.
Comment on attachment 62500 [details] Patch > -#if PLATFORM(WIN) > +#if PLATFORM(WIN) && !OS(WINCE) Why does this matter? Is PLATFORM(WIN) ever true when OS(WINCE) is also true? I think this part of the change is wrong. Comment on attachment 62500 [details] Patch (In reply to comment #2) > (From update of attachment 62500 [details]) > > -#if PLATFORM(WIN) > > +#if PLATFORM(WIN) && !OS(WINCE) > > Why does this matter? Is PLATFORM(WIN) ever true when OS(WINCE) is also true? I think this part of the change is wrong. WinCE+GDI defines PLATFORM(WIN), so it is correct. Cleaning up the PLATFORM() checks for WinCE is IMHO an other task. (e.g. There a too many OS(WINCE) && !PLATFORM(QT)) Comment on attachment 62500 [details]
Patch
That use of PLATFORM(WIN) is going to create tons of problems!
Comment on attachment 62500 [details] Patch Clearing flags on attachment: 62500 Committed r64016: <http://trac.webkit.org/changeset/64016> All reviewed patches have been landed. Closing bug. |