Bug 42917

Summary: Move DocumentLoadTiming struct to a new file
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: New BugsAssignee: Tony Gentilcore <tonyg>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch for landing none

Tony Gentilcore
Reported 2010-07-23 16:24:37 PDT
Move DocumentLoadTiming struct to a new file
Attachments
Patch (11.13 KB, patch)
2010-07-23 16:27 PDT, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.14 KB, patch)
2010-07-26 08:15 PDT, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Gentilcore
Comment 1 2010-07-23 16:27:33 PDT
Created attachment 62472 [details] Patch
Darin Fisher (:fishd, Google)
Comment 2 2010-07-25 21:00:56 PDT
Comment on attachment 62472 [details] Patch WebCore/loader/DocumentLoadTiming.h:35 + : navigationStart(0.0) nit: indent initializer list by 4 spaces r=me otherwise
Tony Gentilcore
Comment 3 2010-07-26 08:15:08 PDT
Created attachment 62575 [details] Patch for landing
Tony Gentilcore
Comment 4 2010-07-26 08:15:57 PDT
(In reply to comment #2) > (From update of attachment 62472 [details]) > WebCore/loader/DocumentLoadTiming.h:35 > + : navigationStart(0.0) > nit: indent initializer list by 4 spaces Oops. Good catch. Fixed. > > > r=me otherwise
WebKit Commit Bot
Comment 5 2010-07-26 10:03:55 PDT
Comment on attachment 62575 [details] Patch for landing Clearing flags on attachment: 62575 Committed r64051: <http://trac.webkit.org/changeset/64051>
WebKit Commit Bot
Comment 6 2010-07-26 10:03:59 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2010-07-26 10:45:10 PDT
http://trac.webkit.org/changeset/64051 might have broken Chromium Win Release The following changes are on the blame list: http://trac.webkit.org/changeset/64050 http://trac.webkit.org/changeset/64051
Note You need to log in before you can comment on or make changes to this bug.