Bug 42917 - Move DocumentLoadTiming struct to a new file
Summary: Move DocumentLoadTiming struct to a new file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-23 16:24 PDT by Tony Gentilcore
Modified: 2010-07-26 10:45 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.13 KB, patch)
2010-07-23 16:27 PDT, Tony Gentilcore 		no flags Details | Formatted Diff | Diff
Patch for landing (11.14 KB, patch)
2010-07-26 08:15 PDT, Tony Gentilcore 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2010-07-23 16:24:37 PDT 
Move DocumentLoadTiming struct to a new file
Comment 1 Tony Gentilcore 2010-07-23 16:27:33 PDT 
Created attachment 62472 [details]
Patch
Comment 2 Darin Fisher (:fishd, Google) 2010-07-25 21:00:56 PDT 
Comment on attachment 62472 [details]
Patch

WebCore/loader/DocumentLoadTiming.h:35
 +        : navigationStart(0.0)
nit: indent initializer list by 4 spaces


r=me otherwise
Comment 3 Tony Gentilcore 2010-07-26 08:15:08 PDT 
Created attachment 62575 [details]
Patch for landing
Comment 4 Tony Gentilcore 2010-07-26 08:15:57 PDT 
(In reply to comment #2)
> (From update of attachment 62472 [details])
> WebCore/loader/DocumentLoadTiming.h:35
>  +        : navigationStart(0.0)
> nit: indent initializer list by 4 spaces

Oops. Good catch. Fixed.

> 
> 
> r=me otherwise
Comment 5 WebKit Commit Bot 2010-07-26 10:03:55 PDT 
Comment on attachment 62575 [details]
Patch for landing

Clearing flags on attachment: 62575

Committed r64051: <http://trac.webkit.org/changeset/64051>
Comment 6 WebKit Commit Bot 2010-07-26 10:03:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2010-07-26 10:45:10 PDT 
http://trac.webkit.org/changeset/64051 might have broken Chromium Win Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/64050
http://trac.webkit.org/changeset/64051