Summary: | [WINCE] Buildfix for GraphicsContext | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aroben, commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Patrick R. Gansterer
2010-07-23 04:35:07 PDT
Created attachment 62410 [details]
Patch
(From attachment 62410 [details]) > - dstRect.move(shadowSize); > + dstRect.move(shadowSize.width(), shadowSize.height()); shadowSize is a FloatSize and dstRect is a IntRect Comment on attachment 62410 [details] Patch In the future, it would be helpful for you to use svn-create-patch rather than plain "svn diff" to create your patches. The former does a few things to make the patches slightly easier to read (like putting function names above each chunk). > @@ -1268,7 +1268,7 @@ > > IntRect dstRect = fillRect; > > - dstRect.move(shadowSize); > + dstRect.move(shadowSize.width(), shadowSize.height()); Is truncating to int really the right thing to do here? r=me, but I'll wait for an answer before marking this cq+. (In reply to comment #3) > Is truncating to int really the right thing to do here? dstRect.inflate(shadowBlur) also casts shadowBlur from float to int. (In reply to comment #4) > (In reply to comment #3) > > Is truncating to int really the right thing to do here? > dstRect.inflate(shadowBlur) also casts shadowBlur from float to int. OK, but that doesn't answer the question. Maybe we should be rounding from float to int in both cases instead of truncating? Created attachment 62438 [details]
Patch
Comment on attachment 62438 [details]
Patch
r=me
Comment on attachment 62438 [details] Patch Clearing flags on attachment: 62438 Committed r63989: <http://trac.webkit.org/changeset/63989> All reviewed patches have been landed. Closing bug. |