Bug 42883

Summary:

Chromium DevTools: migrate from utility context-based injected script dispatch to upstream schema.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit-ews, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed change.	yurys: review+
[PATCH] Tests fixed.	yurys: review+

Pavel Feldman

Reported 2010-07-23 01:49:02 PDT

Patch to follow.

Attachments
[PATCH] Proposed change. (4.90 KB, patch) 2010-07-23 01:50 PDT, Pavel Feldman	yurys: review+	Details Formatted Diff Diff
[PATCH] Tests fixed. (7.78 KB, patch) 2010-07-23 04:50 PDT, Pavel Feldman	yurys: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2010-07-23 01:50:25 PDT

Created attachment 62396 [details] [PATCH] Proposed change.

Pavel Feldman

Comment 2 2010-07-23 04:50:35 PDT

Created attachment 62414 [details] [PATCH] Tests fixed.

Yury Semikhatsky

Comment 3 2010-07-23 04:55:00 PDT

Comment on attachment 62414 [details] [PATCH] Tests fixed. WebCore/inspector/front-end/InjectedScriptAccess.js:40 + else { You don't need "else" since you return from the "if" branch. WebCore/bindings/v8/ScriptProfile.cpp:43 + v8::HandleScope scope; This shouldn't be necessary, please check.

Early Warning System Bot

Comment 4 2010-07-23 04:55:23 PDT

Attachment 62414 [details] did not build on qt: Build output: http://queues.webkit.org/results/3567387

Eric Seidel (no email)

Comment 5 2010-07-23 04:55:59 PDT

Attachment 62414 [details] did not build on mac: Build output: http://queues.webkit.org/results/3580339

WebKit Review Bot

Comment 6 2010-07-23 05:16:31 PDT

http://trac.webkit.org/changeset/63963 might have broken Qt Linux Release minimal and Qt Linux ARMv5 Release

Pavel Feldman

Comment 7 2010-07-23 05:58:45 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/v8/ScriptProfile.cpp M WebCore/inspector/InspectorController.cpp M WebCore/inspector/front-end/InjectedScriptAccess.js M WebKit/chromium/ChangeLog M WebKit/chromium/src/ToolsAgent.h M WebKit/chromium/src/WebDevToolsAgentImpl.cpp M WebKit/chromium/src/WebDevToolsAgentImpl.h M WebKit/chromium/src/js/DevToolsHostStub.js M WebKit/chromium/src/js/InspectorControllerImpl.js Committed r63965

Note You need to log in before you can comment on or make changes to this bug.