Bug 42878

Summary: Backslash isn't transcoded in <input>
Product: WebKit Reporter: Shinichiro Hamaji <hamaji>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, aroben, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1 tkent: review+

Description Shinichiro Hamaji 2010-07-23 00:39:55 PDT
With Bug 39654, font:-webkit-* is considered a explicitly specified font. As these -webkit-* fonts are used internally, we should consider they are not specified explicitly.
Comment 1 Shinichiro Hamaji 2010-07-23 00:46:16 PDT
Created attachment 62388 [details]
Patch v1
Comment 2 Kent Tamura 2010-07-23 00:51:21 PDT
Comment on attachment 62388 [details]
Patch v1

Ok.
Comment 3 Shinichiro Hamaji 2010-07-23 01:38:05 PDT
Committed r63957: <http://trac.webkit.org/changeset/63957>
Comment 4 Shinichiro Hamaji 2010-07-23 13:29:53 PDT
Committed r63995: <http://trac.webkit.org/changeset/63995>
Comment 5 Alexey Proskuryakov 2010-10-01 14:06:07 PDT
This commit changes a lot of results in platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png from PASS to FAIL. Why was this acceptable?

For example, 'Using font "menu". expected: backslash' used to actually have a backslash, but it now has a Yen symbol.

I can't easily tell if these are real failures, or new expected results - in the latter case, the test obviously needs to be updated.
Comment 6 Kent Tamura 2010-10-08 01:08:07 PDT
(In reply to comment #5)
> This commit changes a lot of results in platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png from PASS to FAIL. Why was this acceptable?
> 
> For example, 'Using font "menu". expected: backslash' used to actually have a backslash, but it now has a Yen symbol.
> 
> I can't easily tell if these are real failures, or new expected results - in the latter case, the test obviously needs to be updated.

Agree.  The rendering result looks wrong.

Hamaji-san?
Comment 7 Alexey Proskuryakov 2010-10-08 08:51:16 PDT
Adam filed bug 47017 and bug 47018 to track these problems on Mac and Windows.