| Summary: | Rebaseline fast/dom/prototype-inheritance.html for chromium | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hans Wennborg <hans> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ojan | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Hans Wennborg
2010-07-22 07:56:52 PDT
Created attachment 62297 [details]
Patch
Comment on attachment 62297 [details] Patch Please explain why (in the ChangeLog). Also I see a new baseline for linux but none for Windows. (A windows version of this files exists: http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-win/fast/dom/prototype-inheritance-expected.txt) Why? Comment on attachment 62297 [details] Patch > +++ b/LayoutTests/ChangeLog > @@ -1,3 +1,13 @@ > +2010-07-22 Hans Wennborg <hans@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Rebaseline fast/dom/prototype-inheritance.html for chromium > + https://bugs.webkit.org/show_bug.cgi?id=42824 > + There should be more description here. For example, what revision did it start failing at? That way, the next person who looks at this patch will have enough information to understand why rebaselining is correct. This looks like it's failing on Windows as well. Also, the Windows and Linux expectations for this test should be the same. You shouldn't need to add the linux expected results at all (Linux falls back to the Windows expectations). Weird. I don't know why bugzilla didn't warn me about an update conflict. Sorry for the noise. (In reply to comment #2) > (From update of attachment 62297 [details]) > Please explain why (in the ChangeLog). Done. > > Also I see a new baseline for linux but none for Windows. (A windows version of this files exists: http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-win/fast/dom/prototype-inheritance-expected.txt) Why? Hmm, I simply ran the script, and it must have failed to rebaseline for Windows. When I ran it in the same way today it worked. Thanks for spotting this. Created attachment 62397 [details]
Patch
Comment on attachment 62397 [details]
Patch
If you want this to go into the commit-queue instead of committing it yourself, you'll need to set commit-queue+. In the future if you set commit-queue?, then that lets the reviewer know you want it in the commit-queue once it's approved.
Comment on attachment 62397 [details] Patch Clearing flags on attachment: 62397 Committed r63986: <http://trac.webkit.org/changeset/63986> All reviewed patches have been landed. Closing bug. |