Bug 42824 - Rebaseline fast/dom/prototype-inheritance.html for chromium
Summary: Rebaseline fast/dom/prototype-inheritance.html for chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-22 07:56 PDT by Hans Wennborg
Modified: 2010-07-23 10:27 PDT (History)
2 users (show)

See Also:


Attachments
Patch (43.50 KB, patch)
2010-07-22 07:58 PDT, Hans Wennborg
no flags Details | Formatted Diff | Diff
Patch (2.55 KB, patch)
2010-07-23 01:55 PDT, Hans Wennborg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2010-07-22 07:56:52 PDT
Rebaseline fast/dom/prototype-inheritance.html for chromium
Comment 1 Hans Wennborg 2010-07-22 07:58:30 PDT
Created attachment 62297 [details]
Patch
Comment 2 David Levin 2010-07-22 11:08:34 PDT
Comment on attachment 62297 [details]
Patch

Please explain why (in the ChangeLog).

Also I see a new baseline for linux but none for Windows. (A windows version of this files exists: http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-win/fast/dom/prototype-inheritance-expected.txt) Why?
Comment 3 Ojan Vafai 2010-07-22 11:31:00 PDT
Comment on attachment 62297 [details]
Patch

> +++ b/LayoutTests/ChangeLog
> @@ -1,3 +1,13 @@
> +2010-07-22  Hans Wennborg  <hans@chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Rebaseline fast/dom/prototype-inheritance.html for chromium
> +        https://bugs.webkit.org/show_bug.cgi?id=42824
> +

There should be more description here. For example, what revision did it start failing at? That way, the next person who looks at this patch will have enough information to understand why rebaselining is correct.

This looks like it's failing on Windows as well. Also, the Windows and Linux expectations for this test should be the same. You shouldn't need to add the linux expected results at all (Linux falls back to the Windows expectations).
Comment 4 Ojan Vafai 2010-07-22 11:32:29 PDT
Weird. I don't know why bugzilla didn't warn me about an update conflict. Sorry for the noise.
Comment 5 Hans Wennborg 2010-07-23 01:55:32 PDT
(In reply to comment #2)
> (From update of attachment 62297 [details])
> Please explain why (in the ChangeLog).
Done.

> 
> Also I see a new baseline for linux but none for Windows. (A windows version of this files exists: http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-win/fast/dom/prototype-inheritance-expected.txt) Why?
Hmm, I simply ran the script, and it must have failed to rebaseline for Windows. When I ran it in the same way today it worked. Thanks for spotting this.
Comment 6 Hans Wennborg 2010-07-23 01:55:58 PDT
Created attachment 62397 [details]
Patch
Comment 7 Ojan Vafai 2010-07-23 09:52:23 PDT
Comment on attachment 62397 [details]
Patch

If you want this to go into the commit-queue instead of committing it yourself, you'll need to set commit-queue+. In the future if you set commit-queue?, then that lets the reviewer know you want it in the commit-queue once it's approved.
Comment 8 WebKit Commit Bot 2010-07-23 10:27:51 PDT
Comment on attachment 62397 [details]
Patch

Clearing flags on attachment: 62397

Committed r63986: <http://trac.webkit.org/changeset/63986>
Comment 9 WebKit Commit Bot 2010-07-23 10:27:55 PDT
All reviewed patches have been landed.  Closing bug.