RESOLVED FIXED 42824
Rebaseline fast/dom/prototype-inheritance.html for chromium
https://bugs.webkit.org/show_bug.cgi?id=42824
Summary Rebaseline fast/dom/prototype-inheritance.html for chromium
Hans Wennborg
Reported 2010-07-22 07:56:52 PDT
Rebaseline fast/dom/prototype-inheritance.html for chromium
Attachments
Patch (43.50 KB, patch)
2010-07-22 07:58 PDT, Hans Wennborg
no flags
Patch (2.55 KB, patch)
2010-07-23 01:55 PDT, Hans Wennborg
no flags
Hans Wennborg
Comment 1 2010-07-22 07:58:30 PDT
David Levin
Comment 2 2010-07-22 11:08:34 PDT
Comment on attachment 62297 [details] Patch Please explain why (in the ChangeLog). Also I see a new baseline for linux but none for Windows. (A windows version of this files exists: http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-win/fast/dom/prototype-inheritance-expected.txt) Why?
Ojan Vafai
Comment 3 2010-07-22 11:31:00 PDT
Comment on attachment 62297 [details] Patch > +++ b/LayoutTests/ChangeLog > @@ -1,3 +1,13 @@ > +2010-07-22 Hans Wennborg <hans@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Rebaseline fast/dom/prototype-inheritance.html for chromium > + https://bugs.webkit.org/show_bug.cgi?id=42824 > + There should be more description here. For example, what revision did it start failing at? That way, the next person who looks at this patch will have enough information to understand why rebaselining is correct. This looks like it's failing on Windows as well. Also, the Windows and Linux expectations for this test should be the same. You shouldn't need to add the linux expected results at all (Linux falls back to the Windows expectations).
Ojan Vafai
Comment 4 2010-07-22 11:32:29 PDT
Weird. I don't know why bugzilla didn't warn me about an update conflict. Sorry for the noise.
Hans Wennborg
Comment 5 2010-07-23 01:55:32 PDT
(In reply to comment #2) > (From update of attachment 62297 [details]) > Please explain why (in the ChangeLog). Done. > > Also I see a new baseline for linux but none for Windows. (A windows version of this files exists: http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-win/fast/dom/prototype-inheritance-expected.txt) Why? Hmm, I simply ran the script, and it must have failed to rebaseline for Windows. When I ran it in the same way today it worked. Thanks for spotting this.
Hans Wennborg
Comment 6 2010-07-23 01:55:58 PDT
Ojan Vafai
Comment 7 2010-07-23 09:52:23 PDT
Comment on attachment 62397 [details] Patch If you want this to go into the commit-queue instead of committing it yourself, you'll need to set commit-queue+. In the future if you set commit-queue?, then that lets the reviewer know you want it in the commit-queue once it's approved.
WebKit Commit Bot
Comment 8 2010-07-23 10:27:51 PDT
Comment on attachment 62397 [details] Patch Clearing flags on attachment: 62397 Committed r63986: <http://trac.webkit.org/changeset/63986>
WebKit Commit Bot
Comment 9 2010-07-23 10:27:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.