Bug 42793

Summary:

editing/execCommand/hilitecolor.html and editing/style/remove-underline-from-stylesheet.html should be dumpAsMarkup tests

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Blocker

CC:

enrica, eric, justin.garcia, ojan, tkent, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

27156, 39989

Attachments:

Description	Flags
converts the tests.	darin: review+

Ryosuke Niwa

Reported 2010-07-21 15:53:17 PDT

The following tests should be using dumpAsMarkup editing/execCommand/hilitecolor.html editing/style/remove-underline-from-stylesheet.html editing/undo/redo-style.html

Attachments
converts the tests. (15.26 KB, patch) 2010-07-23 23:45 PDT, Ryosuke Niwa	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2010-07-23 23:33:26 PDT

Turned out that editing/undo/redo-style.html doesn't need to be converted since it's already a dumpAsText test and the output doesn't rely on the DOM or a subtree.

Ryosuke Niwa

Comment 2 2010-07-23 23:45:12 PDT

Created attachment 62489 [details] converts the tests.

Ryosuke Niwa

Comment 3 2010-07-24 15:20:02 PDT

Landed as http://trac.webkit.org/changeset/64013. Thank you for the responsive review, Darin.

Note You need to log in before you can comment on or make changes to this bug.