Bug 42783

Summary: Break out "scheme registration" functionality to a SchemeRegistry
Product: WebKit Reporter: Brady Eidson <beidson>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch ggaren: review+

Description Brady Eidson 2010-07-21 13:43:30 PDT 
Break out "scheme registration" functionality to a SchemeRegistry.

Currently, SecurityOrigin tracks "stuff" about Schemes that can be programmatically registered.  Some of the associations to SecurityOrigin were already kind of loose.

To support future WebKit API we'd like to track other special types of schemes that are in no way related to SecurityOrigin.

We can model MIMETypeRegistry here, as a central holding tank for all Schemes WebCore/WebKit already know about, as well as giving client apps a way to customize things a bit.
Comment 1 Brady Eidson 2010-07-21 14:08:15 PDT 
Created attachment 62229 [details]
Patch
Comment 2 Geoffrey Garen 2010-07-21 14:46:35 PDT 
Comment on attachment 62229 [details]
Patch

WebCore/platform/SchemeRegistry.cpp:94
 +  
Boo on two names for the same thing. I would rename "localSchemes" to "localURLSchemes". (Requires a namespace qualification on the return statement.)

WebCore/platform/SchemeRegistry.cpp:106
 +  
Seems like these fast cases should assert that they're correct. Something like "ASSERT(localSchemes().contains(X))".

r=me
Comment 3 Brady Eidson 2010-07-21 16:20:09 PDT 
Committed r63863: <http://trac.webkit.org/changeset/63863>