Bug 42747

Summary: build-webkit should build MiniBrowser
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: New BugsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, sam, sfalken
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Patch darin: review+

Description Adam Roben (:aroben) 2010-07-21 06:26:22 PDT
build-webkit should build MiniBrowser
Comment 1 Adam Roben (:aroben) 2010-07-21 06:27:34 PDT
Created attachment 62174 [details]
Patch
Comment 2 Darin Adler 2010-07-21 08:17:47 PDT
Comment on attachment 62174 [details]
Patch

Why does MiniBrowser depend on WebKitTestRunner? They should be two independent projects, both depending on WebKit, right?
Comment 3 Adam Roben (:aroben) 2010-07-21 08:34:32 PDT
(In reply to comment #2)
> (From update of attachment 62174 [details])
> Why does MiniBrowser depend on WebKitTestRunner? They should be two independent projects, both depending on WebKit, right?

We require the project dependency tree to be linear so that our "stop the build when any project fails" logic will work. MiniBrowser has no build-time or run-time dependency on WebKitTestRunner, but we mark it as depending on WebKitTestRunner so that Visual Studio won't try to build the two projects in parallel. (Unfortunately, this defeats Visual Studio's project-parallel compilation feature. Fortunately, pdevenv's file-parallel compilation feature mitigates this issue.)
Comment 4 Adam Roben (:aroben) 2010-07-21 09:06:38 PDT
Committed r63827: <http://trac.webkit.org/changeset/63827>