Bug 42701

Summary: WebKitTestRunner needs GCController
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch andersca: review+

Sam Weinig
Reported 2010-07-20 15:18:24 PDT
WebKitTestRunner needs GCController
Attachments
Patch (30.24 KB, patch)
2010-08-07 14:36 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-07-20 15:30:39 PDT
<rdar://problem/8213834>
Sam Weinig
Comment 2 2010-08-07 14:36:08 PDT
Created attachment 63829 [details] Patch
WebKit Review Bot
Comment 3 2010-08-07 14:37:12 PDT
Attachment 63829 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/WebKitTestRunner/InjectedBundle/GCController.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 4 2010-08-07 14:43:05 PDT
Fixed in r64921.
Note You need to log in before you can comment on or make changes to this bug.