Bug 42701 - WebKitTestRunner needs GCController
Summary: WebKitTestRunner needs GCController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-07-20 15:18 PDT by Sam Weinig
Modified: 2010-08-07 14:43 PDT (History)
1 user (show)

See Also:


Attachments
Patch (30.24 KB, patch)
2010-08-07 14:36 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-07-20 15:18:24 PDT
WebKitTestRunner needs GCController
Comment 1 Sam Weinig 2010-07-20 15:30:39 PDT
<rdar://problem/8213834>
Comment 2 Sam Weinig 2010-08-07 14:36:08 PDT
Created attachment 63829 [details]
Patch
Comment 3 WebKit Review Bot 2010-08-07 14:37:12 PDT
Attachment 63829 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/WebKitTestRunner/InjectedBundle/GCController.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Sam Weinig 2010-08-07 14:43:05 PDT
Fixed in r64921.