Bug 42693

Summary: WebKitTestRunner needs layoutTestController.setPrinting
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 116617    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Sam Weinig 2010-07-20 15:15:51 PDT 
WebKitTestRunner needs layoutTestController.setPrinting
Comment 1 Sam Weinig 2010-07-20 15:31:29 PDT 
<rdar://problem/8213845>
Comment 2 Alex Christensen 2013-05-13 16:07:24 PDT 
Created attachment 201643 [details]
Patch
Comment 3 Darin Adler 2013-05-13 16:11:45 PDT 
Comment on attachment 201643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201643&action=review

> Source/WebKit2/ChangeLog:16
> +        (WebPage):

You should leave out this line. It’s really just a symptom of a bug in prepare-ChangeLog.
Comment 4 Alex Christensen 2013-05-13 16:14:38 PDT 
Created attachment 201646 [details]
Patch
Comment 5 Alex Christensen 2013-05-13 17:45:13 PDT 
Created attachment 201651 [details]
Patch
Comment 6 Darin Adler 2013-05-13 17:55:04 PDT 
Comment on attachment 201651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201651&action=review

> Tools/ChangeLog:17
> +        (TestRunner):

Bogus line added by prepare-ChangeLog.

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:879
> +            WKRetainPtr<WKStringRef> text(AdoptWK, WKBundlePageCopyRenderTreeExternalRepresentationForPrinting(m_page));
> +            stringBuilder.append(toWTFString(text));

Should use adoptWK function, not the AdoptWK constructor, here. Also probably reads better without a local variable, like this:

    stringBuilder.append(toWTFString(adoptWK(WKBundlePageCopyRenderTreeExternalRepresentationForPrinting(m_page)).get()));

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:882
> +            WKRetainPtr<WKStringRef> text(AdoptWK, WKBundlePageCopyRenderTreeExternalRepresentation(m_page));
> +            stringBuilder.append(toWTFString(text));        

Ditto.
Comment 7 Alex Christensen 2013-05-13 18:01:56 PDT 
Created attachment 201658 [details]
Patch
Comment 8 WebKit Commit Bot 2013-05-13 19:00:27 PDT 
Comment on attachment 201658 [details]
Patch

Clearing flags on attachment: 201658

Committed r150046: <http://trac.webkit.org/changeset/150046>
Comment 9 WebKit Commit Bot 2013-05-13 19:00:29 PDT 
All reviewed patches have been landed.  Closing bug.