Bug 42682

Summary: WebKitTestRunner needs layoutTestController.setPOSIXLocale
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, mjs, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

Sam Weinig
Reported 2010-07-20 15:12:45 PDT
WebKitTestRunner needs layoutTestController.setPOSIXLocale
Attachments
Patch (5.37 KB, patch)
2011-01-28 17:36 PST, Maciej Stachowiak 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-07-20 15:32:35 PDT
<rdar://problem/8213862>
Maciej Stachowiak
Comment 2 2011-01-28 17:36:41 PST
Created attachment 80529 [details] Patch
Darin Adler
Comment 3 2011-01-28 17:59:05 PST
Comment on attachment 80529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80529&action=review > Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:378 > + JSStringGetUTF8CString(locale, localeBuf, sizeof(localeBuf)); > + setlocale(LC_ALL, localeBuf); Would be nicer to safely do nothing if JSStringGetUTF8CString fails.
Maciej Stachowiak
Comment 4 2011-01-28 18:25:54 PST
Committed r77042: <http://trac.webkit.org/changeset/77042>
WebKit Review Bot
Comment 5 2011-01-28 19:31:25 PST
http://trac.webkit.org/changeset/77042 might have broken GTK Linux 64-bit Debug
Note You need to log in before you can comment on or make changes to this bug.