| Summary: | make dump-as-markup work better on subframes and allow dumping a subtree | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||
| Component: | New Bugs | Assignee: | Ojan Vafai <ojan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, eric, rniwa | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Ojan Vafai
2010-07-20 14:35:14 PDT
Created attachment 62114 [details]
Patch
Comment on attachment 62114 [details] Patch > +// FIXME: Make description required Is this really important? > +/** > + * The description of what this test is testing. Gets prepended to the dumped markup. > + */ Why not use // comments everywhere as we do elsewhere in WebKit? All looks fine. Thanks for the review. (In reply to comment #2) > (From update of attachment 62114 [details]) > > +// FIXME: Make description required > > Is this really important? I'm on the fence. On the one hand it makes the expected results from the test easier to make sense. On the other, it makes tests more of a pain to write. I'll remove the FIXME. > > +/** > > + * The description of what this test is testing. Gets prepended to the dumped markup. > > + */ > > Why not use // comments everywhere as we do elsewhere in WebKit? Ugh. Just habit from Google-style JavaScript. I'll change it over to // comments. Committed r63781: <http://trac.webkit.org/changeset/63781> |