Bug 42662

Summary: When GraphicsLayer::contentsOrientation() is CompositingCoordinatesBottomUp, need to flip repaint rects
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41084    
Attachments:
Description Flags
Patch darin: review+

Simon Fraser (smfr)
Reported 2010-07-20 13:45:18 PDT
When a GraphicsLayer's contentsOrientation() is CompositingCoordinatesBottomUp, we need to flip the rects sent to setNeedsDisplayInRect:, just as we flip when drawing.
Attachments
Patch (8.13 KB, patch)
2010-07-20 14:00 PDT, Simon Fraser (smfr) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2010-07-20 14:00:02 PDT
Created attachment 62108 [details] Patch
Darin Adler
Comment 2 2010-07-20 15:02:34 PDT
Comment on attachment 62108 [details] Patch > + struct objc_super r = { layer, class_getSuperclass(object_getClass(layer)) }; Can you come up with a word to use here, instead of the letter "r"? Maybe "layerSuper" or "receiver" or "layerSuperReceiver" or "superReceiver"?
Simon Fraser (smfr)
Comment 3 2010-07-21 09:56:30 PDT
http://trac.webkit.org/changeset/63835
Note You need to log in before you can comment on or make changes to this bug.