Bug 42662

Summary: When GraphicsLayer::contentsOrientation() is CompositingCoordinatesBottomUp, need to flip repaint rects
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41084    
Attachments:
Description Flags
Patch darin: review+

Description Simon Fraser (smfr) 2010-07-20 13:45:18 PDT 
When a GraphicsLayer's contentsOrientation() is CompositingCoordinatesBottomUp, we need to flip the rects sent to setNeedsDisplayInRect:, just as we flip when drawing.
Comment 1 Simon Fraser (smfr) 2010-07-20 14:00:02 PDT 
Created attachment 62108 [details]
Patch
Comment 2 Darin Adler 2010-07-20 15:02:34 PDT 
Comment on attachment 62108 [details]
Patch

> +        struct objc_super r = { layer, class_getSuperclass(object_getClass(layer)) };

Can you come up with a word to use here, instead of the letter "r"? Maybe "layerSuper" or "receiver" or "layerSuperReceiver" or "superReceiver"?
Comment 3 Simon Fraser (smfr) 2010-07-21 09:56:30 PDT 
http://trac.webkit.org/changeset/63835