Bug 42657

Summary:

[Chromium] Add interface for downloading to a file via WebURLLoader.

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

WebKit API

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
v1 patch	jianli: review+

Description Darin Fisher (:fishd, Google) 2010-07-20 12:34:38 PDT

[Chromium] Add interface for downloading to a file via WebURLLoader.

Comment 1 Darin Fisher (:fishd, Google) 2010-07-20 12:36:56 PDT

Created attachment 62102 [details]
v1 patch

Comment 2 Jian Li 2010-07-20 12:52:18 PDT

Comment on attachment 62102 [details]
v1 patch

Looks good except one minor comment.

WebKit/chromium/public/WebURLLoaderClient.h:56
 +      // Called when a chunk of response data it downloaded.  This is only called
it => is

Comment 3 Darin Fisher (:fishd, Google) 2010-07-20 12:57:14 PDT

Landed as http://trac.webkit.org/changeset/63769