Summary: | focusing an unfocused contentEditable element should place the cursor at the beginning | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||||
Component: | HTML Editing | Assignee: | Ojan Vafai <ojan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, adele, dglazkov, enrica, eric, jparent, justin.garcia, levin, rniwa, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Looks this the body focus case was fixed at http://trac.webkit.org/changeset/14666, but all cases should be doing this though. I don't see when selecting all the node's contents is ever correct. We should either put the cursor at the beginning, or restore the previous selection (as per the FIXME in Element::updateFocusAppearance. I'm running a patch through the layout tests now. Created attachment 62094 [details]
Patch
Comment on attachment 62094 [details]
Patch
This looks sane. I think you're rebaselining some image results you might not need to.
Committed r64488: <http://trac.webkit.org/changeset/64488> http://trac.webkit.org/changeset/64488 might have broken Qt Linux Release |
Created attachment 62087 [details] test case Right now it selected the contents of the element. See test case.