Bug 42646

Summary: focusing an unfocused contentEditable element should place the cursor at the beginning
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: HTML EditingAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adele, dglazkov, enrica, eric, jparent, justin.garcia, levin, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
test case
none
Patch eric: review+

Ojan Vafai
Reported 2010-07-20 09:58:49 PDT
Created attachment 62087 [details] test case Right now it selected the contents of the element. See test case.
Attachments
test case (213 bytes, text/html)
2010-07-20 09:58 PDT, Ojan Vafai 		no flags
Details
Patch (89.65 KB, patch)
2010-07-20 11:25 PDT, Ojan Vafai 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2010-07-20 10:40:17 PDT
Looks this the body focus case was fixed at http://trac.webkit.org/changeset/14666, but all cases should be doing this though. I don't see when selecting all the node's contents is ever correct. We should either put the cursor at the beginning, or restore the previous selection (as per the FIXME in Element::updateFocusAppearance. I'm running a patch through the layout tests now.
Ojan Vafai
Comment 2 2010-07-20 11:25:28 PDT
Created attachment 62094 [details] Patch
Eric Seidel (no email)
Comment 3 2010-08-02 12:10:33 PDT
Comment on attachment 62094 [details] Patch This looks sane. I think you're rebaselining some image results you might not need to.
Ojan Vafai
Comment 4 2010-08-02 13:46:29 PDT
Committed r64488: <http://trac.webkit.org/changeset/64488>
WebKit Review Bot
Comment 5 2010-08-02 14:04:53 PDT
http://trac.webkit.org/changeset/64488 might have broken Qt Linux Release
Note You need to log in before you can comment on or make changes to this bug.