| Summary: | HTML5 tree builder should restore form state | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, darin, eric | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 41123 | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2010-07-20 09:23:11 PDT
Created attachment 62083 [details]
Patch
Comment on attachment 62083 [details]
Patch
r=me
I think it would be good to add some sort of debug assertion that every element gets a finishParsingChildren call before some later point in time, so we could see more directly, rather than indirectly, that every element gets it.
> I think it would be good to add some sort of debug assertion that every element gets a finishParsingChildren call before some later point in time, so we could see more directly, rather than indirectly, that every element gets it.
That sounds like a good idea. When should we fire that ASSERT?
Comment on attachment 62083 [details]
Patch
LGTM too.
(In reply to comment #3) > That sounds like a good idea. When should we fire that ASSERT? One possibility is to walk the whole just-parsed tree and perhaps even the whole document as well firing that assert any time the parser finishes parsing. Another possibility is to fire the assertion at element destructor time. I think there are other possible times as well that won’t necessarily be quite as good: One is event dispatch, but there are probably lots of others. Anything that doesn’t happen during parsing, but almost always happens later could fit the bill. It's unclear to me if "finishedParsingChildren" will be required in the end. It's part of the old parser's logic, but we might need an equivalent in the new parser too. (In reply to comment #6) > It's unclear to me if "finishedParsingChildren" will be required in the end. It's part of the old parser's logic, but we might need an equivalent in the new parser too. I’m pretty sure that this or the equivalent will be needed. We removed it from the old parser at one point, and then had to add it back. Does it only get called for parser-inserted elements? I guess I could look in the debugger. (In reply to comment #8) > Does it only get called for parser-inserted elements? I guess I could look in the debugger. It goes hand in hand with a "created by parser" flag passed when the element is created. Comment on attachment 62083 [details] Patch Clearing flags on attachment: 62083 Committed r63760: <http://trac.webkit.org/changeset/63760> All reviewed patches have been landed. Closing bug. |