Summary: | Following change @62542, webkit doesn't compile when the inspector is disabled | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Leon Clarke <leonclarke> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | android-webkit-unforking, commit-queue, pfeldman, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Leon Clarke
2010-07-20 05:54:57 PDT
Created attachment 62059 [details]
Proposed fix
Hm. Can we hide InspectorDOMAgent instead? At first glance,it looks like that will be a more complex change, however it may well be philosophically tidier. I'll investigate a bit more... Created attachment 62072 [details]
Removing whole InspectorDOMAgent
That looks like a good idea, removing the whole InspectorDOMAgent
That patch was missing a file. Hang on... Created attachment 62080 [details]
And again with all the files
Comment on attachment 62080 [details] And again with all the files Clearing flags on attachment: 62080 Committed r63753: <http://trac.webkit.org/changeset/63753> All reviewed patches have been landed. Closing bug. |