Bug 42632

Summary: Following change @62542, webkit doesn't compile when the inspector is disabled
Product: WebKit Reporter: Leon Clarke <leonclarke>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Severity: Normal CC: android-webkit-unforking, commit-queue, pfeldman, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Description Flags
Proposed fix
Removing whole InspectorDOMAgent
pfeldman: review+, leonclarke: commit-queue-
And again with all the files none

Description Leon Clarke 2010-07-20 05:54:57 PDT
...and Android currently doesn't use the inspector.
Comment 1 Leon Clarke 2010-07-20 05:58:04 PDT
Created attachment 62059 [details]
Proposed fix
Comment 2 Pavel Feldman 2010-07-20 06:17:35 PDT
Hm. Can we hide InspectorDOMAgent instead?
Comment 3 Leon Clarke 2010-07-20 06:27:32 PDT
At first glance,it looks like that will be a more complex change, however it may well be philosophically tidier. I'll investigate a bit more...
Comment 4 Leon Clarke 2010-07-20 07:04:11 PDT
Created attachment 62072 [details]
Removing whole InspectorDOMAgent

That looks like a good idea, removing the whole InspectorDOMAgent
Comment 5 Leon Clarke 2010-07-20 08:26:41 PDT
That patch was missing a file. Hang on...
Comment 6 Leon Clarke 2010-07-20 08:38:29 PDT
Created attachment 62080 [details]
And again with all the files
Comment 7 WebKit Commit Bot 2010-07-20 10:35:56 PDT
Comment on attachment 62080 [details]
And again with all the files

Clearing flags on attachment: 62080

Committed r63753: <http://trac.webkit.org/changeset/63753>
Comment 8 WebKit Commit Bot 2010-07-20 10:36:00 PDT
All reviewed patches have been landed.  Closing bug.