Bug 42623

Summary: [Qt] Setup the QtWebProcess
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: WebKit2Assignee: Balazs Kelemen <kbalazs>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, diegohcg, hausmann, kenneth, koivisto, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch
none
proposed patch
none
proposed patch with style fixes none

Balazs Kelemen
Reported 2010-07-20 03:08:15 PDT
Since we have the port of the webkit2 core, it is time to setup our WebProcess, creating the entry point and the build environment.
Attachments
proposed patch (9.23 KB, patch)
2010-07-20 05:06 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
proposed patch (10.09 KB, patch)
2010-07-20 05:27 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
proposed patch with style fixes (10.09 KB, patch)
2010-07-23 04:39 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2010-07-20 05:06:22 PDT
Created attachment 62055 [details] proposed patch
WebKit Review Bot
Comment 2 2010-07-20 05:09:01 PDT
Attachment 62055 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/qt/MainQt.cpp:27: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/qt/MainQt.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit2/WebProcess/qt/WebProcessMainQt.cpp:27: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/qt/WebProcessMainQt.cpp:28: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/qt/WebProcessMainQt.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 5 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Balazs Kelemen
Comment 3 2010-07-20 05:27:31 PDT
Created attachment 62056 [details] proposed patch Add WebProcessMainQt.cpp to SOURCES in WebCore.pro, what I forgot in the previous patch.
WebKit Review Bot
Comment 4 2010-07-20 05:29:37 PDT
Attachment 62056 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/qt/MainQt.cpp:27: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/qt/MainQt.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit2/WebProcess/qt/WebProcessMainQt.cpp:27: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/qt/WebProcessMainQt.cpp:28: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/qt/WebProcessMainQt.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 5 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Balazs Kelemen
Comment 5 2010-07-23 04:39:27 PDT
Created attachment 62412 [details] proposed patch with style fixes
WebKit Review Bot
Comment 6 2010-07-23 04:41:56 PDT
Attachment 62412 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/qt/MainQt.cpp:27: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/qt/WebProcessMainQt.cpp:27: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/qt/WebProcessMainQt.cpp:29: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/qt/WebProcessMainQt.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 4 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andras Becsi
Comment 7 2010-07-23 06:39:38 PDT
Comment on attachment 62412 [details] proposed patch with style fixes Clearing flags on attachment: 62412 Committed r63968: <http://trac.webkit.org/changeset/63968>
Andras Becsi
Comment 8 2010-07-23 06:39:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.