| Summary: | [Qt] Setup the QtWebProcess | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Balazs Kelemen <kbalazs> | ||||||||
| Component: | WebKit2 | Assignee: | Balazs Kelemen <kbalazs> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abecsi, diegohcg, hausmann, kenneth, koivisto, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Balazs Kelemen
2010-07-20 03:08:15 PDT
Created attachment 62055 [details]
proposed patch
Attachment 62055 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/qt/MainQt.cpp:27: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/qt/MainQt.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:27: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:28: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 5 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 62056 [details]
proposed patch
Add WebProcessMainQt.cpp to SOURCES in WebCore.pro, what I forgot in the previous patch.
Attachment 62056 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/qt/MainQt.cpp:27: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/qt/MainQt.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:27: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:28: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 5 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 62412 [details]
proposed patch with style fixes
Attachment 62412 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/qt/MainQt.cpp:27: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:27: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:29: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessMainQt.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 4 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 62412 [details] proposed patch with style fixes Clearing flags on attachment: 62412 Committed r63968: <http://trac.webkit.org/changeset/63968> All reviewed patches have been landed. Closing bug. |