Bug 42609

Summary: clean up style in ClipboardWin and PasteboardWin
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Tony Chang
Reported 2010-07-19 18:16:00 PDT
clean up style in ClipboardWin and PasteboardWin
Attachments
Patch (24.55 KB, patch)
2010-07-19 18:20 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (24.55 KB, patch)
2010-07-19 18:24 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.70 KB, patch)
2010-07-19 18:41 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-07-19 18:20:27 PDT
Created attachment 62020 [details] Patch
Tony Chang
Comment 2 2010-07-19 18:24:17 PDT
Created attachment 62021 [details] Patch
Tony Chang
Comment 3 2010-07-19 18:24:41 PDT
Comment on attachment 62021 [details] Patch This is a precursor to fixing bug 37981
Kent Tamura
Comment 4 2010-07-19 18:31:18 PDT
Comment on attachment 62021 [details] Patch > if (getWebLocData(dataObject, url, title)) { > success = true; > - return url; > } else if (SUCCEEDED(dataObject->GetData(urlWFormat(), &store))) { nit: We can remove {}. > - //URL using unicode > + // URL using unicode nit: unicode -> Unicode > - //URL using ascii > + // URL using ascii nit: ascii -> ASCII > - //unicode text > + // unicode text ditto. > - //ascii text > + // ascii text ditto.
Tony Chang
Comment 5 2010-07-19 18:41:10 PDT
Created attachment 62023 [details] Patch for landing
WebKit Commit Bot
Comment 6 2010-07-20 01:43:57 PDT
Comment on attachment 62023 [details] Patch for landing Clearing flags on attachment: 62023 Committed r63734: <http://trac.webkit.org/changeset/63734>
WebKit Commit Bot
Comment 7 2010-07-20 01:44:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.