Bug 42602

Summary: Implement NPN_PostURLNotify
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2010-07-19 15:56:54 PDT
Implement NPN_PostURLNotify
Attachments
Patch (20.30 KB, patch)
2010-07-19 16:15 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-07-19 16:15:18 PDT
Created attachment 62008 [details] Patch
WebKit Review Bot
Comment 2 2010-07-19 16:21:01 PDT
Attachment 62008 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:359: NPN_PostURLNotify is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit2/WebProcess/Plugins/PluginController.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2010-07-19 16:23:17 PDT
Comment on attachment 62008 [details] Patch I am not sure all the inline's are necessary.
Anders Carlsson
Comment 4 2010-07-19 17:08:07 PDT
Committed r63701: <http://trac.webkit.org/changeset/63701>
Note You need to log in before you can comment on or make changes to this bug.