Bug 42586 – Log all canceled authentication attempts in DumpRenderTree

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

DumpRenderTree already prints a log when it responds with preset credentials, but it doesn't log anything when there are no credentials (and it thus simulates a canceled auth sheet).

It's important to know whether an auth sheet appeared.

[Alexey Proskuryakov]

Created attachment 61980 [details]
proposed patch

[Darin Adler]

Comment on attachment 61980 [details]
proposed patch

> +        NSString *string = [NSString stringWithFormat:@"%@ - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet", identifier];
> +        printf("%s\n", [string UTF8String]);

I would either use puts instead of printf here, or continue to use printf but use UTF8String on the identifier instead of calling stringWithFormat and have a printf format string instead.

r=me

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/63681>.

> I would either use puts instead of printf here, or continue
> to use printf but use UTF8String on the identifier instead of
> calling stringWithFormat and have a printf format string instead.

I didn't make this change, since such style matches what is done elsewhere in this file.

[WebKit Review Bot]

http://trac.webkit.org/changeset/63681 might have broken Qt Linux Release