Bug 42584

Summary: Add local storage support for WebKit2
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

Description Sam Weinig 2010-07-19 12:37:13 PDT
Add local storage support for WebKit2
Comment 1 Sam Weinig 2010-07-19 12:37:57 PDT
Created attachment 61978 [details]
Patch
Comment 2 Anders Carlsson 2010-07-19 12:57:03 PDT
Comment on attachment 61978 [details]
Patch

> Index: WebKit2/Shared/WebPreferencesStore.h
> ===================================================================
> --- WebKit2/Shared/WebPreferencesStore.h	(revision 63671)
> +++ WebKit2/Shared/WebPreferencesStore.h	(working copy)
> @@ -105,6 +109,8 @@ struct WebPreferencesStore {
>      WebCore::String fixedFontFamily;
>      WebCore::String sansSerifFontFamily;
>      WebCore::String serifFontFamily;
> +
> +    WebCore::String localStorage;
>  };
>  
Looks like this isn't used?

Do you also need to remove files from the Skipped list?
Comment 3 Sam Weinig 2010-07-19 13:07:12 PDT
(In reply to comment #2)
> (From update of attachment 61978 [details])
> > Index: WebKit2/Shared/WebPreferencesStore.h
> > ===================================================================
> > --- WebKit2/Shared/WebPreferencesStore.h	(revision 63671)
> > +++ WebKit2/Shared/WebPreferencesStore.h	(working copy)
> > @@ -105,6 +109,8 @@ struct WebPreferencesStore {
> >      WebCore::String fixedFontFamily;
> >      WebCore::String sansSerifFontFamily;
> >      WebCore::String serifFontFamily;
> > +
> > +    WebCore::String localStorage;
> >  };
> >  
> Looks like this isn't used?

Oops. Removed.

> Do you also need to remove files from the Skipped list?

No, these have not been added yet.
Comment 4 Sam Weinig 2010-07-19 13:08:22 PDT
Landed in r63682.